Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730764 --- Comment #6 from Michael Schwendt <mschwe...@gmail.com> 2012-05-04 18:58:10 EDT --- I wonder, why in comment 1 rpmlint is quoted without commenting on it? > wxpdfdoc.spec:49: W: rpm-buildroot-usage %build make > -C build prefix=$RPM_BUILD_ROOT%{_prefix} all -f GNUmakefile > $RPM_BUILD_ROOT should not be touched during %build or %prep stage, > as it may break short circuit builds. Actually, there is a bigger risk than that. This buildroot path may enter the built files as part of any path that is derived from the "prefix" value. It's a common packaging pitfall. So, avoid using $RPM_BUILD_ROOT or %buildroot prior to %install. > Group: Development/Libraries Base libs typically enter group "System Environment/Libraries" instead. > gcc-c++ This is covered by: https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 Hard-requiring gcc-c++ also makes it less simple to rebuild within a replaced minimum build environment. > %package devel > Requires: wxpdfdoc https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %files > %{_libdir}/libwxcode_gtk2_pdfdoc* I'd like to see a test-build of the package to judge about whether this %files section is correct. > %files devel > %{_includedir}/wx/pdf* > %{_prefix}/src/pdf* The -devel package would need to depend on wxGTK-devel for proper dir ownership. And the usage of /usr/src needs a look at the test-build, too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
