Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=821890 Kevin Fenzi <ke...@scrye.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org |ke...@scrye.com Flag| |fedora-review+ --- Comment #1 from Kevin Fenzi <ke...@scrye.com> 2012-05-15 15:09:04 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: (Sources do match up, md5 difference is due to timestamps) 87ae6e18ac9b477df50ea8df762c0ea1 trac-sphinx-plugin-0.2.1.20120515.hge021e691af84.tar.gz 93fb5087f811a3f4d9d02528e31069e4 trac-sphinx-plugin-0.2.1.20120515.hge021e691af84.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: trac-sphinx-plugin.src: W: invalid-url Source0: trac-sphinx-plugin-0.2.1.20120515.hge021e691af84.tar.gz 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Can be ignored. I see no blockers here, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
