Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=767985 Michael Schwendt <mschwe...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #16 from Michael Schwendt <mschwe...@gmail.com> 2012-05-16 13:29:10 EDT --- From the diff between -3 and -4: + +%post +#clear out the cache directory so all future pages are regenerated with the new build +rm -f %{_prefix}/cache/man2html/* || : + + %{_prefix} here is wrong. You did want %{_localstatedir}, but you could use /var instead and everywhere else (not just in the patch files). Again, macros here only add value, if you substituted their values also in the source code. That isn't done for /usr and /var, and not /etc either, so hardcoding /usr and /var (and derived paths) would make sense and would be acceptable, too. Rule of thumb: If you "rpmbuild --rebuild --define "foo bar" …" the src.rpm, the redefined macro values ought to find their way into the built rpms, too. If that isn't the case, the builds are broken due to a mismatch between paths in %files section, scriptlets, and in files included in the package. The wrong prefix can be fixed in Fedora package git, of course. Welcome to the packager group! [...] Apart from that, installing the builds of man2html-1.6-4.g.fc17.src.rpm now makes the three CGI executables work by default. hman also works great now using xdg-open. (Neat with an already open Firefox, isn't it?). man2html-core succeeds, too. Also the -h option. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
