https://bugzilla.redhat.com/show_bug.cgi?id=823043
--- Comment #4 from Shawn Iwinski <shawn.iwin...@gmail.com> --- (In reply to comment #3) > (In reply to comment #2) > > I would prefer to add all of the extensions phpci found instead of > > determining > > which ones are included in core or other packages so would the following be > > acceptable?: > > > > Requires: php-mbstring --> separate package > > Requires: php-pcre --> included in php-common package > > Requires: php-posix --> included in separate php-process package > > Requires: php-readline --> included in separate php-cli package > > ok with me, I would prefer this too, You never know when an extension might > be moved out of core in the future. Glad we think alike > > Since this is a console library, would it make sense to require "php-cli" > > instead of "php-common" since "php-cli" provides /usr/bin/php for > > "#!/usr/bin/php" or "#!/usr/bin/env php" script usage? > > No, php-common is still better. This might for example be running in a unit > testing web environment, which doesn't have php-cli. Note that phpci found the readline extension dependency which would be provided by php-readline which is a virtual package of php-cli [1]. I'll keep the php-common requirement, but I just wanted to note that the php-cli package would be installed anyway. [1] http://pkgs.fedoraproject.org/gitweb/?p=php.git;a=blob;f=php.spec;h=a224e69538d4b848bbebec39ce8c352c8be80d78;hb=HEAD#l143 -- You are receiving this mail because: You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
