https://bugzilla.redhat.com/show_bug.cgi?id=817302
--- Comment #2 from Christof Damian <chris...@damian.net> ---
Some fixes are needed, mostly about the requires.
Issues:
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr(....) present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
[!]: MUST Requires correct, justified where necessary.
- requires php instead of php-common
- I think there are some required extensions missing. Some are optional, but
for example dom doesn't seem to be optional
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
