Idézés Xavier <[EMAIL PROTECTED]>: > Nagy Gabor wrote: > >> Nagy Gabor wrote: > >>>> commit f43805d875ad5c672afbbfff48bded2087204773 > >>>> Author: Chantry Xavier<[EMAIL PROTECTED]> > >>>> Date: Sat May 10 18:47:42 2008 +0200 > >>>> > >>>> Cleanup usages of alpm_list_find and alpm_list_remove. > >>>> > >>>> * remove obsolete and unused *_cmp helper functions like > deppkg_cmp > >> and > >>>> _alpm_grp_cmp > >>>> > >>>> * new alpm_list_remove_str function, used 6 times in handle.c > >>>> > >>>> * remove _alpm_prov_cmp / _alpm_db_whatprovides and replace them > by > >>>> a more general alpm_find_pkg_satisfiers with a cleaner > >> implementation. > >>>> before: alpm_db_whatprovides(db, targ) > >>>> after: alpm_find_pkg_satisfiers(alpm_db_getpkgcache(db), targ) > >>> Warning: pkg literal also satisfies pkg. But in most cases we called > >>> what_provides if we didn't find a literal. > >>> > > > > Yes, there is no problem with this (I just emphasized it). I like the new > > function better because I think find_satisfiers is quite a common task. > Btw, as > > I see, after this patch pacman -S 'kernel26>=2.6.24' automagically works, > which > > is cool imho. > > > > I am glad you liked at least one thing about my patch :) > >
If we like this then we could document it. But unfortunately in case of versioned dependencies the "literal first" rule disappear. We need something similar to "search for satisfier part" of resolvedeps. Maybe we could move that part to its own function and somehow use it. Bye P.S.: Sorry for "chit-chat", this is my last year in uni (hopefully;), I'm quite busy now. But in summer holiday patch flood will come... ;-) ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/ _______________________________________________ pacman-dev mailing list pacman-dev@archlinux.org http://archlinux.org/mailman/listinfo/pacman-dev
