Idézés Dan McGee <[EMAIL PROTECTED]>: > On Tue, Jul 15, 2008 at 6:36 AM, Nagy Gabor <[EMAIL PROTECTED]> wrote: > > >From b9673a106b1f985cb81f620f394620e6eca88516 Mon Sep 17 00:00:00 2001 > > From: Nagy Gabor <[EMAIL PROTECTED]> > > Date: Tue, 15 Jul 2008 13:30:34 +0200 > > Subject: [PATCH] Fix some memleaks in alpm/add.c > > > > In case of error some allocated memory wasn't freed in commit_single_pkg. > > Note: The return value of this function is not used. > > > > Signed-off-by: Nagy Gabor <[EMAIL PROTECTED]> > > --- > > Thanks. Perhaps we should use the return value? >
Well, now our add code won't stop in case of error just go ahead;-) As I guessed this behaviour change was introduced by commit 591bfabbd38bf4f8f209977f416a4e5fd3cc2baf, where we split the huge add_commit function. So to answer to your question, I think we should. Others? Bye ---------------------------------------------------- SZTE Egyetemi Könyvtár - http://www.bibl.u-szeged.hu This mail sent through IMP: http://horde.org/imp/ _______________________________________________ pacman-dev mailing list pacman-dev@archlinux.org http://archlinux.org/mailman/listinfo/pacman-dev
