On Tue, Jun 29, 2010 at 11:28 PM, Denis A. Altoé Falqueto <[email protected]> wrote: > On Wed, Jun 30, 2010 at 1:04 AM, Allan McRae <[email protected]> wrote: >> That would be a great start. If those changes are still big, then break >> them down further into logical components. > > One question: can I edit that big patch to extract the several parts > or do i need to create real commits in my branch? I understand that > the documentation of git-format-patch suggests the former. I just > would like a confirmation from you, more experienced users.
Take a look at the "Splitting commits" section in http://www.kernel.org/pub/software/scm/git/docs/git-rebase.html for some helpful advice. I would highly recommend working on your own work branch and making as many commits as you want in the future; when you realize a lot of those are fixups you can easily go back with git-rebase and reshape the whole patch set. We will always prefer 5 or 6 commits here rather than 1 giant patch dump. -Dan
