On Sun, Apr 3, 2011 at 6:55 AM, Sebastian Nowicki <seb...@gmail.com> wrote: > Looks like there are more warnings when using gnu89: > > $ make 2>&1 | grep 'warning:' | cut -d' ' -f3- | sort | uniq -c > 74 comma at end of enumerator list > 1 initializer element is not computable at load time > 7 ISO C90 does not support the 'j' gnu_printf length modifier > 106 ISO C90 does not support the 'z' gnu_printf length modifier > 41 ISO C90 forbids mixed declarations and code > 57 ISO C90 forbids specifying subobject to initialize > >
There are lots of duplicates (173 -> 58 warnings after removing them). 4 commas at the end of enumerator lists are a C99-specific feature [-pedantic] 2 extension used [-pedantic] 50 ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement] 2 variable declaration in for loop is a C99-specific feature [-pedantic] Seems like I was also confused by the high number of repetition of the first warning in my previous post. My opinion is still the same though : - commas the end of enum lists : much nicer for adding new items at the end - variable declaration in for loop : further reducing of variable scope. its silly to always need to put the i in the outer block.