On 20 April 2011 16:01, Dan McGee <[email protected]> wrote: > On Wed, Apr 20, 2011 at 12:56 AM, Rémy Oudompheng > <[email protected]> wrote: > > On Tue 19 April 2011 at 23:19 +0300, [email protected] wrote: > >> From: Ivan Kanakarakis <[email protected]> > >> > >> Denis' patch applied to master > >> > >> --- > >> scripts/pacman-key.sh.in | 520 > ++++++++++++++++++++++++--------------------- > >> 1 files changed, 277 insertions(+), 243 deletions(-) > >> > > > > Hello, > > > > This patch seems to apply random whitespace changes over all the file. > > Could you resend it without the whitespace changes so that it is easier > > to see what has changed? > > More to the point- this patch has an awful commit message, as do the > others in the series, so I won't look at them until that is fixed. > > 1. I don't know what is even being done by this (see the subject), and > the commit message helps less- it needs to be a paragraph summary of > what you are trying to accomplish. > 2. Please use sentences, paragraphs, capital letters, and punctuation > around here. > > http://www.archlinux.org/pacman/submitting-patches.html > > -Dan > > Alright, I'll try again then. Sorry for the fuss. Just a question, commits like the 2nd one in this series, that change just a line in a function but are not directly related to the problem one is trying to solve, should they be separate or is it better to be rebased/merged with some other bigger commit ?
-- Ivan c00kiemon5ter V Kanak http://c00kiemon5ter.github.com
