On 21 April 2011 20:00, Dan McGee <[email protected]> wrote: > On Thu, Apr 21, 2011 at 8:59 AM, <[email protected]> wrote: > > From: Ivan Kanakarakis <[email protected]> > > > > This commit correctly redirects to /dev/null the output of several > > commands that get executed on logic checks. > > > > Signed-off-by: Ivan Kanakarakis <[email protected]> > > Why? I personally hate losing everything, especially stderr, to the > trap that is /dev/null. Once there is problem most people like to know > what is actually going on rather than our likely oversimplified error > message. > > -Dan > >
Of the 5 changes in this commit the last 2 hid stderr too. I'm used to hiding all output from a command in a logic check, and extensively checking return codes (provided the command returns different error codes for each failing case). I also see this as a more uniform style. Not something really important. -- Ivan c00kiemon5ter V Kanak http://c00kiemon5ter.github.com
