On 13/04/12 00:54, Dave Reisner wrote: > Pass $(OURSCRIPTS) through the bash parser in read only mode to validate > syntax. Note that this doesn't actually catch all errors, but it might > be useful for developers working on these scripts. > > Signed-off-by: Dave Reisner <[email protected]> > --- > contrib/Makefile.am | 1 + > scripts/Makefile.am | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/contrib/Makefile.am b/contrib/Makefile.am > index eca39e7..2953912 100644 > --- a/contrib/Makefile.am > +++ b/contrib/Makefile.am > @@ -55,6 +55,7 @@ $(OURSCRIPTS): Makefile > $(AM_V_GEN)$(edit) $(srcdir)/[email protected] >[email protected] > $(AM_V_at)chmod +x,a-w [email protected] > $(AM_V_at)mv [email protected] $@ > + @$(BASH_SHELL) -O extglob -n $@
I'm missing why we need extglob here? > $(OURFILES): Makefile > $(AM_V_at)$(RM) $@ [email protected] > diff --git a/scripts/Makefile.am b/scripts/Makefile.am > index b8a1990..dbe61b8 100644 > --- a/scripts/Makefile.am > +++ b/scripts/Makefile.am > @@ -63,6 +63,7 @@ edit = sed \ > $(OURSCRIPTS): Makefile > $(AM_V_at)$(RM) $@ > $(AM_V_GEN)test -f $(srcdir)/[email protected] && m4 -P -I $(srcdir) > $(srcdir)/[email protected] | $(edit) >$@ > + @$(BASH_SHELL) -O extglob -n $@ > $(AM_V_at)chmod +x,a-w $@ > > makepkg: \
