On 07/01/17 02:14, Eli Schwartz wrote: > On 01/04/2017 12:35 AM, Allan McRae wrote: >> This will not be included. We have already rejected additions for >> several other editors (and the vim mode lines already annoy me...) > > Okay. Will you accept a patch to add vim modelines to every single file > in libmakepkg instead? Because it seems to be missing from there ;) and > I only noticed the problem after writing a bunch of changes and noticing > the diff was horribly screwed up. > > I didn't even realize that this project used vim modelines until you > said something, but I haven't really looked at the C part. > > Personally, I saw EditorConfig and said "this is finally the solution". > It lets you specify project coding standards in machine-readable format > *once* and then editors get to interpret that, e.g. via editor plugins > created by the EditorConfig project. But hey, standards proliferate and > all that, I get where you are coming from too. > > Please do reconsider as Christian Hesse said, whether it makes sense to > switch now, once, and get rid of modelines forever. But I am okay with > either solution, so long as I don't have to deal with my default > settings clashing with the project standards. >
I'd prefer no vim modelines and no editorconfig file. Allan (Aren't editors smart enough these days to recognise that files full with tab indents should be tab indented...)