Exactly, if they have PACKAGER set then we don't make any guesses at all, they've already told us exactly what they want.
On Wed, Feb 1, 2017, 8:43 AM Dave Reisner, <[email protected]> wrote: > On Feb 1, 2017 08:33, "Kieran Colford" <[email protected]> wrote: > > Would you care to share with us what pile of shit it returns? I can't fix > something when I don't know what's wrong. > > I never suggested that we work around laziness, people should absolutely > configure their system properly (I personally think violators should be > punished with regular kernel panics, but I don't think Linus will accept my > patch). > > I'm just trying to give default values that conform to what a user expects > to see: if they added a real name on account creation then it should show > up wherever a real name is needed, if they set the EMAIL environment > variable then software should assume that's the user's email and use it. > Those are both recommended by the wiki too. > > > And if they set PACKAGER it leaks into makepkg just the same, but better? > > > > On Wed, Feb 1, 2017, 12:47 AM Allan McRae, <[email protected]> wrote: > > > On 01/02/17 08:10, Kieran Colford wrote: > > > The system usually has enough information in various places to guess > > > the name and email of the person running the makepkg script. Use these > > > instead of defaulting to "Unknown Packager" to minimize configuration > > > necessary by the user. This particular implemenation should provide > > > relatively good guess that's compatible with other programs > > > (i.e. git). > > > > > > Signed-off-by: Kieran Colford <[email protected]> > > > > This returns a pile of shit on my system.... We are not going to work > > around laziness. > > > > A > > > -- > > Signed, Kieran Colford > -- Signed, Kieran Colford
