On 4 June 2018 at 08:48, Allan McRae <al...@archlinux.org> wrote: > On 31/05/18 23:31, Alex Butler wrote: > > Adds opt-in lz4 compression of *pkg.tar files with makepkg. > > This is nice to have as an option for very fast compression > > and is already installed with libarchive. > > > > Signed-off-by: Alex Butler<alexhere...@gmail.com> > > --- > > This patch is fine in principle. But I think we need to figure out what > to do with all the COMPRESS* options. This will make seven of them and > we have a request for another compression method too. There has to be a > more efficient way of overriding the range of compression options. > > Perhaps. Though adding a new libarchive-supported compression option currently costs 1 line of code, 1 line of conf & 1 line of docs. I'd say that was pretty good.
I also don't see that this patch particularly complicates any future efforts to improve the compression handling.