On 9/10/18 12:19 pm, Andrew Gregory wrote:
> On 10/09/18 at 02:20am, Morgan Adamiec wrote:
>> On 09/10/2018 2:15 am, Allan McRae wrote:
>>> On 9/10/18 11:05 am, morganamilo wrote:
>>>> static struct pkg_operations local_pkg_ops = {
>>>> - .get_base = _cache_get_base,
>>>> - .get_desc = _cache_get_desc,
>>>> - .get_url = _cache_get_url,
>>>> - .get_builddate = _cache_get_builddate,
>>>> - .get_installdate = _cache_get_installdate,
>>>> - .get_packager = _cache_get_packager,
>>> <snip>
>>>> + .get_base = _cache_get_base,
>>>> + .get_desc = _cache_get_desc,
>>>> + .get_url = _cache_get_url,
>>>> + .get_builddate = _cache_get_builddate,
>>>> + .get_installdate = _cache_get_installdate,
>>> ...
>>>
>>> Is there any objection to killing this formatting rather than having a
>>> lot of uselessness in the patch.
>>>
>>> A
>>>
>>
>> I could split adding the fields and the formatting to two patches if you
>> prefer? Easier to read diffs and the struct stays pretty.
>
> Kill the formatting. We've had this discussion before, for this very
> feature even:
> https://lists.archlinux.org/pipermail/pacman-dev/2017-January/021784.html
> .
>
OK - a patch to kill the formating, then this patch rebased on top.
A
