On 09/20/18 at 05:43am, Dave Reisner wrote: > Use BytesIO instead of StringIO, and ensure that we unicode-encode data > where needed. > ---
Any particular reason for the bump or just dropping the (allegedly) dead python2? I've held off from doing this so far because asciidoc is python2, hoping they'd update to python3 eventually. It appears to be dead now, though, so I guess it's time to move on. ... > diff --git a/test/pacman/pmdb.py b/test/pacman/pmdb.py > index f7671987..26a8d9a4 100644 > --- a/test/pacman/pmdb.py > +++ b/test/pacman/pmdb.py > @@ -17,9 +17,10 @@ > > import os > import shutil > -from StringIO import StringIO > import tarfile > > +from io import BytesIO > + Why the extra line breaks around the new imports? They were grouped by built-in vs local.
