On Tue, Dec 04, 2018 at 09:27:52AM -0500, Eli Schwartz wrote: > On 12/4/18 7:56 AM, Dave Reisner wrote: > > On Tue, Dec 04, 2018 at 05:14:50PM +1000, Allan McRae wrote: > >> On 4/12/18 12:36 am, Dave Reisner wrote: > >>> This lets developers run a local build with optimizations but also the > >>> added debug logging that comes with PACMAN_DEBUG being defined. > >>> --- > >> > >> So, we only test for "debug" to enable anything. What options starting > >> with debug would be used here? > > > > meson understands --buildtype=debug and --buildtype=debugoptimized when > > you configure the build. Before this patch, only the former buildtype is > > accepted in order to trigger these extra flags. After, both buildtypes > > are. > > > >> Also, all those warning flags in this test are set with --enable-warning > >> flags in autotools based builds. Strangely, all the options from > >> --enable-debug are not set here... > > > > I chose not to add a -Ddebug=true flag to the meson build and instead > > key off of the buildtype. With this patch, I'm essentially suggesting > > that developers who want a suitable debugging build should just build as > > --buildtype=(debug|debugoptimized). That gives you the extra warning > > flags and extra timestamp logging just the same as --enable-debug and > > --enable-warning-flags gave you with autotools. > > > > Do you feel there's reason to separate these concerns? > When using makepkg to build pacman-git, I use --buildtype=plain and let > makepkg.conf handle debug builds. But maybe I still want the timestamping.
For c/c++ builds, --buildtype=debug isn't more than --buildtype=plain with an added -g flag. I'm not sure how this would get in your way.