On 2/12/19 5:27 PM, Sever Oraz wrote: > Signed-off-by: Sever Oraz <[email protected]> > ---
The new patch seems to have the advertised result without side effects. As a general rule when it comes to submitting patches, the commit message should not record the fact that it is a second attempt, nor how the first attempt was buggy. I would suggest a commit message like: ``` Use standard, consistent units in the download progress. Rather than use M/s which can be either MB or MiB, specify that it uses MiB (consistent with the displayed total size). Fixes FS#59201 ``` Comments that are pertinent to the mailing list discussion but not to the commit message can be inserted after the --- and before the diff header, as such: --- [additional comments go here] src/pacman/callback.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) git send-email has an --annotate option that lets you add comments before submitting. -- Eli Schwartz Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
