On 13/3/19 2:01 am, Que Quotion wrote: > From: Que Quotion <[email protected]> > > Signed-off-by: Que Quotion <[email protected]> > --- > The word 'build' can be vague: as a verb in can be used to describe > the entire process of rendering a package tarball from a PKGBUILD, > while on these lines it refers to a specific PKGBUILD function. > > We need to more effectively discourage packagers from doing things > like generating makefiles in prepare(), where the scripts these > options trigger are not called to set or unset their flags. > > doc/PKGBUILD.5.asciidoc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >
I'm accepting this as is, because it represents an improvement on the current man page. But should at least makeflags mention all of build(), check() and package()? A > diff --git a/doc/PKGBUILD.5.asciidoc b/doc/PKGBUILD.5.asciidoc > index e8ce691f..7d6f3271 100644 > --- a/doc/PKGBUILD.5.asciidoc > +++ b/doc/PKGBUILD.5.asciidoc > @@ -296,23 +296,23 @@ underscore and the architecture name e.g., > 'replaces_x86_64=()'. > Compress man and info pages with gzip. > > *ccache*;; > - Allow the use of ccache during build. More useful in its > negative > + Allow the use of ccache during `build()`. More useful in its > negative > form `!ccache` with select packages that have problems building > with ccache. > > *distcc*;; > - Allow the use of distcc during build. More useful in its > negative > + Allow the use of distcc during `build()`. More useful in its > negative > form `!distcc` with select packages that have problems building > with distcc. > > *buildflags*;; > Allow the use of user-specific buildflags (CPPFLAGS, CFLAGS, > CXXFLAGS, > - LDFLAGS) during build as specified in linkman:makepkg.conf[5]. > More > + LDFLAGS) during `build()` as specified in > linkman:makepkg.conf[5]. More > useful in its negative form `!buildflags` with select packages > that > have problems building with custom buildflags. > > *makeflags*;; > - Allow the use of user-specific makeflags during build as > specified > + Allow the use of user-specific makeflags during `build()` as > specified > in linkman:makepkg.conf[5]. More useful in its negative form > `!makeflags` with select packages that have problems building > with > custom makeflags such as `-j2` (or higher).
