%X is locale-dependent, making it impossible to reliably parse and potentially overflowing the buffer. %T is consistent across locales.
Also fixes some adjacent whitespace. Signed-off-by: Andrew Gregory <[email protected]> --- lib/libalpm/log.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/log.c b/lib/libalpm/log.c index d8842a55..2ff5544b 100644 --- a/lib/libalpm/log.c +++ b/lib/libalpm/log.c @@ -39,11 +39,11 @@ static int _alpm_log_leader(FILE *f, const char *prefix) { time_t t = time(NULL); struct tm *tm = localtime(&t); - int length = 32; - char timestamp[length]; + int length = 32; + char timestamp[length]; /* Use ISO-8601 date format */ - strftime(timestamp,length,"%FT%X%z", tm); + strftime(timestamp,length,"%FT%T%z", tm); return fprintf(f, "[%s] [%s] ", timestamp, prefix); } -- 2.21.0
