On 10/7/19 10:59 PM, Allan McRae wrote: > On 8/10/19 12:48 pm, Eli Schwartz wrote: >> On 10/7/19 10:34 PM, Allan McRae wrote: >>> On 8/10/19 7:18 am, Eli Schwartz wrote: >>>> This breaks reproducible builds due to encoding information specific to >>>> the filesystem which was used to build the package, information which we >>>> are never interested in for packaging purposes anyway. >>>> >>>> It also means that attempting to extract a package file as root (or >>>> fakeroot) might result in angry warnings being printed to the console by >>>> bsdtar, followed by a non-zero exit code, unless the user remembers to >>>> use --no-fflags during extraction. This is unpleasant UI, even if pacman >>>> itself won't care about these. >>> >>> What warnings? How would I replicate those warnings? I am currently >>> not seeing any... >> >> An example package is the current pacman-contrib-1.2.0-2 package in >> [community] -- it has the nocow attribute, because it must have been >> built on a CoW-supporting filesystem. >> >> Try extracting it using `sudo bsdtar` or `fakeroot bsdtar`, and if the >> filesystem you extract it to is NOT a CoW-supporting filesystem it will >> complain. >> >> For example, it worked for me originally, because my rootfs is a BTRFS >> filesystem and I extracted it to a subdirectory of $HOME, but, when I >> repeated the experiment in /tmp, I got the complaints. >> > > Ah - I misread your commit message.
s/This/fflags/ > I thought adding the --no-fflags > option resulted in an error when extracting the package with bsdtar. > > Patch is good then. > > Allan > -- Eli Schwartz Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature