On 10/24/19 3:28 AM, a...@eckner.net wrote: > Since the update to pacman 5.2.0, `makepkg --printsrcinfo` may emmit > warnings about invalid packager format. However, all config variables in > /etc/makepkg.conf, as well as directory permissions are not relevant if > `--printsrcinfo` is given. So we simply skip the lint_conf and directory > permisison checks then.
The warning about PACKAGER is already fixed on master, by only emitting the warning when the value is both non-default (by default it is unset and therefore uses the internal fallback "Unknown Packager") and an invalid format. So we should no longer have issues when using the stock, unmodified makepkg.conf -- is it actually worth skipping it entirely? The directory permission checks skipping argument logically applies to --packagelist too, and to go one step further, if we're going to have special handling of this we should also avoid, for example, checking BUILDDIR when running --verifysource or --geninteg. (But we'd still want to check SRCDEST, then). All that being said, the only directory being checked at all is $PWD unless you've overridden it via your makepkg.conf, in which case I would've presumed it would be writable. :/ -- Eli Schwartz Bug Wrangler and Trusted User
signature.asc
Description: OpenPGP digital signature
