Allan McRae pushed to branch master at Pacman / Pacman
Commits: 18e49f2c by Levente Polyak at 2023-11-17T18:56:44+01:00 debugflags: ensure to only append debug flags once when building During a package build we call prepare_buildenv in multiple stages of the process. For debug packages, one of the hooks is buildenv_debugflags which populates the debug flags to the according variables. The issue is that the behavior of the current implementation of buildenv_debugflags is not idempotent, so consecutive calls will append the same flags again. In certain cases this isn't an issue, however for context aware build frontends like cargo any change of the build inputs leads to a fresh build. This means that any invocation of such a build ecosystem inside the package() function will trigger a full rebuild, which is not desired. To fix this issue, this commit makes buildenv_debugflags idempotent by only appending flags once to the target variables. Signed-off-by: Levente Polyak <[email protected]> - - - - - 4 changed files: - scripts/libmakepkg/buildenv/debugflags.sh.in - scripts/libmakepkg/buildenv/lto.sh.in - scripts/libmakepkg/buildenv/rust.sh.in - scripts/libmakepkg/util/util.sh.in View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/18e49f2c97f0e33a645f364ed9de8e3da6c36d41 -- View it on GitLab: https://gitlab.archlinux.org/pacman/pacman/-/commit/18e49f2c97f0e33a645f364ed9de8e3da6c36d41 You're receiving this email because of your account on gitlab.archlinux.org.
