Steve Hay schrieb:
Grr. That fixes the scandeps program output, but doesn't fix my PAR problem because PAR::Packer::pack_manifest_hash() directly calls Module::ScanDeps::add_deps() later on (line 739 of VERSION 0.975). It is *that* call which actually adds Decrypt.dll to the PAR package, and once again that call is screwed up if the foreach-loop in Module::ScanDeps::scan_deps() has been run earlier.

Hi Steve,

I'm still puzzled and can't spend a lot of time on this, sorry. If you apply the attached patch to the svn head, does it help? It's not a solution, but I'd rather have duplicates than missed dlls.

On a side note: Do you think it would be possible to write a short test for the bug? If so, please feel free to commit it to the repository.

Best regards,
Steffen

=== lib/Module/ScanDeps.pm
==================================================================
--- lib/Module/ScanDeps.pm      (revision 1827)
+++ lib/Module/ScanDeps.pm      (local)
@@ -470,7 +470,8 @@
             warn "# Couldn't find include name for $path\n" if $warn;
         }
     } else {
-        (my $vol, my $dir, $inc_name) = File::Spec->splitpath($path);
+        #(my $vol, my $dir, $inc_name) = File::Spec->splitpath($path);
+ $inc_name = $path; # prefer duplicates over missed shared libraries!
     }

     return $inc_name;

Reply via email to