Sun May 16 10:22:54 2010: Request 57494 was acted upon.
Transaction: Correspondence added by SMUELLER
       Queue: PAR-Packer
     Subject: Re: [rt.cpan.org #57494] JSON::Any doesn't package in PAR?
   Broken in: (no value)
    Severity: (no value)
       Owner: Nobody
  Requestors: [email protected]
      Status: open
 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=57494 >


Hi Roderich,

Roderich Schupp via RT wrote:
>        Queue: PAR-Packer
>  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=57494 >
> 
> Following up on my previous post:
> 
> - JSON::XS needs "attributes.pm" which can't be autodetected.
>   We could add a special rule to Module::ScanDeps for this.

Ah, another one of those ugly implicit dependencies.

>   But as it turns out, "attributes.pm" is another one of those modules
>   that might be implicitly require'd by the Perl runtime itself
>   (like "Errno.pm" or "PerlIO.pm"), I'm inclined to add it to the
>   list of "always pack" modules (cf. sub require_modules
>   in PAR-Packer/script/par.pl).
> 
>   @Steffen: What do you think?

I don't think have have a choice other than to do that.

> - JSON needs a special rule in Module::ScanDeps to add all of
> 
> JSON/PP.pm
> JSON/PP5005.pm
> JSON/PP58.pm
> JSON/PP
> JSON/PP/Boolean.pm
> JSON/PP56.pm
> 
> This will do the trick:
> 
>     'JSON.pm' => sub {
>         # ignore other JSON::* modules (e.g. JSON::Syck, JSON::Any),
>         # but accept JSON::XS (because JSON.pm might use it if present)
>         return( grep /^JSON\/(PP|XS)/, _glob_in_inc('JSON', 1) );
>     },

This looks correct.

Best regards,
Steffen

Reply via email to