Mon Dec 05 06:08:44 2011: Request 72954 was acted upon.
Transaction: Correspondence added by RSCHUPP
Queue: Module-ScanDeps
Subject: ":encoding(UTF-8)" doesn't imply a dependency on Encode.pm
Broken in: 1.07
Severity: Normal
Owner: RSCHUPP
Requestors: [email protected]
Status: open
Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=72954 >
Proposed fix:
diff -ubr Module-ScanDeps-1.07/lib/Module/ScanDeps.pm
Module-ScanDeps-next/lib/Module/ScanDeps.pm
--- Module-ScanDeps-1.07/lib/Module/ScanDeps.pm 2011-11-28
16:51:47.000000000 +0100
+++ Module-ScanDeps-next/lib/Module/ScanDeps.pm 2011-12-05
12:05:39.385682000 +0100
@@ -914,8 +914,10 @@
return "DBD/$1.pm" if /\b[Dd][Bb][Ii]:(\w+):/;
if (/(?:(:encoding)|\b(?:en|de)code)\(\s*['"]?([-\w]+)/) {
my $mod = _find_encoding($2);
- return [ 'PerlIO.pm', $mod ] if $1 and $mod;
- return $mod if $mod;
+ my @mods = ( 'Encoding.pm' ); # always needed
+ push @mods, 'PerlIO.pm' if $1; # needed for
":encoding(...)"
+ push @mods, $mod if $mod; # "external" Encode module
+ return \@mods;
}
return $1 if /^(?:do|require)\s+[^"]*"(.*?)"/;
return $1 if /^(?:do|require)\s+[^']*'(.*?)'/;