Reini Urban rur...@x-ray.at
On Mar 7, 2013, at 3:05 AM, Roderich Schupp <roderich.sch...@googlemail.com> wrote: > On Wed, Mar 6, 2013 at 10:51 PM, Reini Urban <rur...@x-ray.at> wrote: >> All this because of a wrong logic in the main Makefile.PL ("double >> negation always causes trouble") > > From your patch: > > --- ./Makefile.PL.orig 2013-03-06 15:39:37.239573200 -0600 > +++ ./Makefile.PL 2013-03-06 15:42:37.344245200 -0600 > @@ -100,7 +100,7 @@ > > # Do not run 10parl-generation tests in case of a pre built .par > (doesn't work) > my %tests = map { $_ => 1 } <t/*.t>; > - delete $tests{'t/10-parl-generation.t'} unless (!$par and $cc); > + delete $tests{'t/10-parl-generation.t'} if ($par or !$cc); > > makemaker_args( > MAN1PODS => { > @@ -117,9 +117,7 @@ > 'script/tkpp', > ], > DIR => [ > - (!$par and $cc) ? ( > - 'myldr' > - ) : (), > + ($par or !$cc) ? () : ('myldr') > ], > > > > That's BS. Might be. Looks wrong of course. But it's your code and it fixed my problem and it looks better that the old code. Please think of a non-BS fix.