Mon Nov 09 18:04:44 2020: Request 132067 was acted upon.
Transaction: Correspondence added by SLAFFAN
Queue: PAR-Dist
Subject: fix for Archive::Zip related test failures due to symlinks
Broken in: (no value)
Severity: (no value)
Owner: Nobody
Requestors: slaf...@cpan.org
Status: open
Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=132067 >
On Sun Nov 08 20:21:12 2020, nie...@users.sourceforge.net wrote:
> On Sun Nov 08 19:55:28 2020, nie...@users.sourceforge.net wrote:
> > On Thu Mar 05 17:43:33 2020, SLAFFAN wrote:
> > > Many of the current CPAN test failures have this error text (links
> > > below):
> > >
> > > error: Could not extract /tmp/par4D_mq/blib/META.yml safely: /tmp
> > > is
> > > an existing symbolic link
> > >
> > >
> > >
> > > One simple fix is to ensure _unzip_to_tmpdir (or perhaps _unzip)
> > > uses
> > > a path with symlinks resolved.
> > >
> > > For example in _unzip_to_tmpdir:
> > >
> > > ...
> > > my $path = $tmpdir;
> > > $path = File::Spec->catdir($tmpdir, $args{subdir}) if defined
> > > $args{subdir};
> > > ### add these two lines
> > > require Cwd;
> > > $path = Cwd::realpath($path);
> > >
> > > _unzip(dist => $dist, path => $path);
> > > ...
> > >
> > >
> > > Tested on macos 10.15.
> > >
> > > Let me know if you'd prefer a patch file, and whether it should be
> > > in
> > > _unzip_to_tmpdir or more localised within _unzip.
> > >
> > > Shawn.
> >
> > Could you post your current WIP patch? Happy to test on BigSur RC.
> > Thanks.
>
> Never mind. I see the provided snippet now. It works with BigSur and
> the system perl-5.28(.2)
Thanks for testing and confirming.
Roderich - would it be possible to get this applied? I can work up a PR or
patch if you prefer.
