On Sunday 21 June 2009 21:48:38 [email protected] wrote:

> --- trunk/src/key.c   Mon Jun 22 04:21:49 2009        (r39699)
> +++ trunk/src/key.c   Mon Jun 22 04:48:36 2009        (r39700)
> @@ -617,11 +617,13 @@
>  {
>      ASSERT_ARGS(key_mark)
>      const UINTVAL flags = PObj_get_FLAGS(key) & KEY_type_FLAGS;
> -    PMC          *next_key;
>
>      if (flags == KEY_string_FLAG) {
>          STRING *str_key;
>          GETATTR_Key_str_key(interp, key, str_key);
> +
> +        /* XXX str_key can be NULL from GETATTR_Key_str_key, */
> +        /* so shouldn't be marked. */
>          Parrot_gc_mark_PObj_alive(interp, (PObj *)str_key);
>      }

That would explain some strange bugs actually.

-- c
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev

Reply via email to