On Fri, Feb 20, 2009 at 01:21:12PM +0100, Jim Meyering wrote: > Joel Granados <[email protected]> writes: > > On Thu, Feb 19, 2009 at 06:08:26PM +0100, Jim Meyering wrote: > >> Joel Granados Moreno <[email protected]> writes: > >> > * libparted/labels/gpt.c (_parse_header()) : The problem is that > >> > last_usable_if_grown and last_usable_min_default should be both CPU > >> > format, but last_usable_if_grown is converted to LE64. Patch taken from > >> > parted mailing list, author (petr.uzel at suse.cz). > >> > >> Thanks. > >> That patch looks like it's probably ok, but, > >> please run git commit --amend --author '...' and then adjust the log: > >> it need not mention authorship, since git's headers will do that. > >> Also, if you can include a URL for the message, that'd be nice, > >> especially if it includes more details, e.g., on how to produce the > >> failure. > >> > >> If there is a convenient reproducer, let me know and I'll add a test. > > > > The url does not state additional. > > Is there a problem report? > > I'm wary of any patch that comes without a problem report > and without a recipe for reproducing some failure. The url is http://lists.alioth.debian.org/pipermail/parted-devel/2008-October/thread.html. I don't see any additional relevant info. As for a reprodusable issue... well I don't see one either. I just did a thorough study of the code and it seems that we are making a mistake here.
Petr: is there additional info on how to hit this? -- Joel Andres Granados Brno, Czech Republic, Red Hat. _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
