Otavio Salvador wrote:
> I've did a fix to get parted building again in s390 (fdasd label).
> Please take a look at:
>
> http://git.debian.org/?p=parted/debian/parted.git;a=commit;h=d3def58a37fcac156a14c2aea098c90ffd6fea7d
>
> I think we ought to commit it in master for the release. If people ack
> it I can push it.

>From your commit message I cannot tell that it fixes
a compilation or link failure (implied by what you say above).
Please show us how the current code fails on s390 and adjust
your log message to start with something like this:

    build/fdasd: avoid compilation failure on s390

Also, this part looks like it won't always work:

    -                       arch/$(OS).c
    +                       arch/$(OS).c            \
    +                       arch/$(OS).h

since there is no .h file when $(OS) is "gnu" or "beos".

_______________________________________________
parted-devel mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/parted-devel

Reply via email to