Colin Watson wrote: > On Tue, Apr 13, 2010 at 07:50:08PM +0200, Jim Meyering wrote: >> Thanks! This looks great. >> I've applied it with some small changes. > [...] > > Looks good to me. Thanks. > >> - squashed in the patch below, to: >> * fix typo s/2>1/2>&1/ > > Note that that was just a copy-and-paste from further up, so I'd > recommend correcting the other identical typo in > tests/t1700-ext-probe.sh too. > >> * make false-positive test for "ext4" less likely: >> a) parted's -m option gives more parseable output >> b) test for more explicit regexp that should not match, say, >> the absolute device name that "parted ...print" prints > > The same probably goes for this.
Thanks for mentioning that. I've done so: >From 34c9c11cbfe944587ceb22b96f61441c4b4328c5 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Tue, 13 Apr 2010 21:17:50 +0200 Subject: [PATCH] tests: propagate recent improvements to copied-from code * tests/t1700-ext-probe.sh: Fix typo s/2>1/2>&1/ and use a tighter regexp also in the preceding loop. Noted by Colin Watson. --- tests/t1700-ext-probe.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/t1700-ext-probe.sh b/tests/t1700-ext-probe.sh index 62ca8e5..e898381 100755 --- a/tests/t1700-ext-probe.sh +++ b/tests/t1700-ext-probe.sh @@ -40,8 +40,8 @@ for type in ext2 ext3 ext4; do mkfs.$type -F $dev >/dev/null || fail=1 # probe the $type file system - parted -s $dev print >out 2>1 || fail=1 - grep -w $type out || fail=1 + parted -m -s $dev u s print >out 2>&1 || fail=1 + grep '^1:.*:'$type'::;$' out || fail=1 done -- 1.7.1.rc1.248.gcefbb _______________________________________________ parted-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/parted-devel
