[snip]
Mightn't it be better if we always listened on the unix socket, and if
we want to listen on TCP then do that in addition, rather than
instead? Then ssh-mode and tcp-mode can be used on the same server,
etc.
Sure. Just 2 things:
* if we do that, we lose the ability to automatically find the tcp port
number it is on if the offset is tweaked. But I guess that if you tweak the
offset when you start it, you can also apply the same offset when you "list"
or "attach". And you can always use the socket for doing "stop". So that's
ok.
Oh, right, finding the port again. Users might want to be able to do that.
Yes, I think they would... ;)
The other option is to just leave out the "choose a different base
port" option. The port ends up being "a + b", where "b" is fully under
the user's control. So giving them control over "a" really doesn't
give them any extra power, but skipping it lets us avoid nasty and
confusing UI possibilities.
I'm not sure I am following you... Can you provide a sample command line
usage?
* Not sure what the code will look like when listening to 2 sockets...
A bit more work there... Any ideas on that?
This is actually really simple. Right now, the code does:
make a socket
register a callback on the socket that calls accept() and go from there
In the Brave New Multi-socket World, the code just does that twice.
Cool.
What happens if 2 separate clients connect to both sockets. Does one
kick the other out? (no biggie)
Probably should refactor a bit, so that the socket creation and
binding happens in the script code, and XpraServer.__init__ just takes
a list of sockets and registers its callbacks on them. But that's just
polish.
I've already done something along those lines.
[snip]
Thanks
Antoine
_______________________________________________
Parti-discuss mailing list
[email protected]
http://lists.partiwm.org/cgi-bin/mailman/listinfo/parti-discuss
