On Wed, Apr 23, 2014 at 4:01 AM, Von Welch <[email protected]> wrote: > It'd be nice if you could develop consistent style for $variable vs >> ${variable}, but for the most part, things look okay now. > > > I tend to use the brackets if I think it makes for easier-to-read code, > but it's fairly subjective and I don't feel strongly. Looks like you prefer > the first form unless you are using a modifier? >
More or less, or when next to something odd in a quoted string. > > One thing I'd like to see in the harness is generating new gpg keys on the >> fly, but perhaps this is unnecessary. > > > I don't see the value off-hand > Okay. > > Another thing is I'd like to keep setup.sh fairly lean, and move any of >> those functions that aren't needed globally into the specific tests >> themselves. But for now, again, things seem fine. > > > Every function is used in multiple tests, or at least I envision it will > be once we have a full suite. In any case, I suggest waiting to do that > optimization until you have a complete suite. > Agreed.
_______________________________________________ Password-Store mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/password-store
