On 09-05-14 13:08:30, Svend Sorensen wrote:
Cayetano Santos <[email protected]>
writes:

  Here you have the patch. It includes:

  - variables password-length and timeout

I like the variable password-length. Pass reads the
PASSWORD_STORE_CLIP_TIME environmental variable, so I will update the
emacs package to do the same.

OK, good idea.


  - password-store-contents returns all text in entry

I like this too. I am wondering if this should be the default for
password-store-get, or at least an option.

  - password-store-url expects 'url : htt....'

I am thinking of moving password-store-url out of password-store into an
add-on package. I'd like to keep the focus of the emacs password-store
package to be the same as the password-store project.

+1 for having password-store-core.el or similar as a wrapper to the cli tool, 
and extra packages
implementing higher level (thematic?) routines (browse url, etc.; 
password-store-contents would go
to the core, while password-store-get would return given fields - password, 
username,
whatever). Easier to mantain and follow core features.


  I included too a few comments to declare env variables for gpg-agent use.

The various PASSWORD_STORE_* environmental variables that are used
should be documented. I think instructions for getting gpg-agent working
should be documented in the README or a wiki.

I vote for the README. When you download the package, you get it.


I can implement these changes, or if you can send me separate patches
generated by git-format-patch, I can apply those.

Please, go ahead.

c.

Thanks!
_______________________________________________
Password-Store mailing list
[email protected]
http://lists.zx2c4.com/mailman/listinfo/password-store

Reply via email to