On Sun, Jul 08, 2012 at 05:11:24PM -0400, Tom Rondeau wrote: > Hey Martin, > > I've applied these patches locally. I'm working on a number of patches > that have been submitted all at once, so this should be pushed later > today. > > I wish I had looked at this just a few hours ago. Johnathan and I are > working on some major updates on another branch where I also fixed > these, but in different ways. We'll just have to deal with the > conflicts when they come up now, though. Oh well.
Sure :) Just to clarify: for the most examples, I simply changed them from 'not working' to 'working', and I don't care how that's done. However, for ber_simu.grc and pam_sync.grc, I actually think my solution is an improvement over the one in master (ber_simu.grc because of Eb/N0, pam_sync.grc in my patch uses a scatterplot instead of scope plot for the post-sync signal and fixes some labels, so now you can see when your sync is working because you see a nice constellation diagram). MB > > Thanks, > Tom > > > On Thu, Jul 5, 2012 at 12:23 PM, Martin Braun (CEL) > <martin.br...@kit.edu> wrote: > > Hi, > > > > I wanted to use the GRC examples in gr-digital in class recently--turns > > out they're all broken :( > > > > Here's three patches: > > > > - The first changes ber_simu.grc to use Eb/N0 instead of the noise > > amplitude, which I find very unintuitive. You can now look up the > > theoretical BER for a given Eb/N0 and, after the BER average is done, > > you will see the textbook value. Also it uses more constellation > > object properties. > > - The second actually fixes a bug in the GRC bindings, which made the > > DPSK modulators unusable in GRC. > > - The final patch fixes the other GRC files (none of which would run). > > In most cases, the files were probably just copied when stuff moved to > > gr-digital, and API changes were not reflected. > > > > The patches seem bigger than they are; that's because I also moved the > > blocks around. I guess this could count as 'gratuitious white space > > changes', but considering they didn't work before, I hope that's OK. > > > > On a sidenote, it would be great if we had unit tests for GRC files > > (both .grc and .xml block bindings). Won't promise to write them myself, > > though, just saying :) > > > > MB > > > > > > -- > > Karlsruhe Institute of Technology (KIT) > > Communications Engineering Lab (CEL) > > > > Dipl.-Ing. Martin Braun > > Research Associate > > > > Kaiserstraße 12 > > Building 05.01 > > 76131 Karlsruhe > > > > Phone: +49 721 608-43790 > > Fax: +49 721 608-46071 > > www.cel.kit.edu > > > > KIT -- University of the State of Baden-Württemberg and > > National Laboratory of the Helmholtz Association > > > > _______________________________________________ > > Patch-gnuradio mailing list > > Patch-gnuradio@gnu.org > > https://lists.gnu.org/mailman/listinfo/patch-gnuradio > > > > _______________________________________________ > Patch-gnuradio mailing list > Patch-gnuradio@gnu.org > https://lists.gnu.org/mailman/listinfo/patch-gnuradio -- Karlsruhe Institute of Technology (KIT) Communications Engineering Lab (CEL) Dipl.-Ing. Martin Braun Research Associate Kaiserstraße 12 Building 05.01 76131 Karlsruhe Phone: +49 721 608-43790 Fax: +49 721 608-46071 www.cel.kit.edu KIT -- University of the State of Baden-Württemberg and National Laboratory of the Helmholtz Association
pgpBDJUGheKuy.pgp
Description: PGP signature
_______________________________________________ Patch-gnuradio mailing list Patch-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/patch-gnuradio