Patches item #1062060, was opened at 2004-11-07 21:15 Message generated for change (Comment added) made by irmen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1062060&group_id=5470
Category: Library (Lib) Group: Python 2.4 Status: Open Resolution: None Priority: 6 Submitted By: Irmen de Jong (irmen) Assigned to: Nobody/Anonymous (nobody) Summary: fix for 1016880 urllib.urlretrieve silently truncates dwnld Initial Comment: The patch makes urllib.urlretrieve raise an IOError if the actual download size is different from the expected size (taken from the content-length header). ---------------------------------------------------------------------- >Comment By: Irmen de Jong (irmen) Date: 2004-12-24 15:10 Message: Logged In: YES user_id=129426 Yes I'm having trouble building the docs from source, so I will just add the text that I would like to change in the docs. When I have some time left (it's Christmas after all :) ) I'll also create a regression test for the new behavior. In the meantime, the "urllib.patch" may be deleted because "urllib.patch2" is the correct patch (I seem to be unable to delete the attachment myself) ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2004-12-21 01:00 Message: Logged In: YES user_id=80475 Irmin, please attach the new patch. If you're having trouble with the docs, that's fine, just include the text you want changed. Do include tests with your patch. ---------------------------------------------------------------------- Comment By: Johannes Gijsbers (jlgijsbers) Date: 2004-12-06 22:48 Message: Logged In: YES user_id=469548 Sorry Irmen, I'm a bit late with this, but now is the time to get new "features" checked into the trunk. Could you add a doc patch that explains the behavior as you did in your previous message and a tests patch? I can check it in then. ---------------------------------------------------------------------- Comment By: Irmen de Jong (irmen) Date: 2004-11-07 21:54 Message: Logged In: YES user_id=129426 NOTE: urllib.patch2 may be a bit better. It fixes a misspelling, and also is more relaxed about a 'wrong' download size. To be more precise: it treats content-length as a lower bound (just like wget and firefox appear to do). So if there's more data to read, it reads more data, but if less data is available, it gives an IOError ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1062060&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
