Patches item #1094015, was opened at 2005-01-01 09:26
Message generated for change (Comment added) made by jlgijsbers
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1094015&group_id=5470

Category: Library (Lib)
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Reinhold Birkenfeld (birkenfeld)
Assigned to: Nobody/Anonymous (nobody)
Summary: Improvements for shutil.copytree()

Initial Comment:
See bugs #975763 and #1048878.

The patch changes shutil.copytree() to use
os.makedirs() instead of os.mkdir() and to copy
directory bits using copystat(), because file bits are
copied, too.

It includes a doc change to mention these details.

----------------------------------------------------------------------

>Comment By: Johannes Gijsbers (jlgijsbers)
Date: 2005-01-23 13:21

Message:
Logged In: YES 
user_id=469548

I see. I've moved the copystat call to after the loop in
rev. 1.36.

----------------------------------------------------------------------

Comment By: Thomas Waldmann (thomaswaldmann)
Date: 2005-01-17 01:10

Message:
Logged In: YES 
user_id=100649

For files, the ctime and atime is copied, too, as part of
copystat() - directly AFTER copying the file.

But if the copystat() call for a directory is done BEFORE
filling that directory with files, the atime and mtime of
the directory will be changed by that again.

So better move the copystat call for the directory to after
the for loop.


----------------------------------------------------------------------

Comment By: Johannes Gijsbers (jlgijsbers)
Date: 2005-01-08 13:32

Message:
Logged In: YES 
user_id=469548

Applied on HEAD. Thanks for the patch! Log message:

Checking in Doc/lib/libshutil.tex;
/cvsroot/python/python/dist/src/Doc/lib/libshutil.tex,v  <--
 libshutil.tex
new revision: 1.16; previous revision: 1.15
done
Checking in Lib/shutil.py;
/cvsroot/python/python/dist/src/Lib/shutil.py,v  <--  shutil.py
new revision: 1.35; previous revision: 1.34
done


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1094015&group_id=5470
_______________________________________________
Patches mailing list
[email protected]
http://mail.python.org/mailman/listinfo/patches

Reply via email to