Patches item #853890, was opened at 2003-12-04 03:05 Message generated for change (Comment added) made by rupole You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=853890&group_id=5470
Category: Core (C code) Group: None Status: Open Resolution: None Priority: 5 Submitted By: Roger Upole (rupole) Assigned to: Nobody/Anonymous (nobody) Summary: Optional keyword unicode args not handled correctly Initial Comment: Added a case for 'u' in skipitem in getargs.c ---------------------------------------------------------------------- >Comment By: Roger Upole (rupole) Date: 2005-03-28 17:04 Message: Logged In: YES user_id=771074 After taking another look at this, all the arguments it processes are pointers. Since they're not actually changed by this function, they can all be treated as void *, eliminating the case stmt altogether and effectively future-proofing the function. With as little code as is left, and since it's only called from one place, inlining it might be feasible. This leaves out validation of the format char, but I'd say it's up to whoever constructs the argument format to make sure it works correctly when you pass in a matching arg. ---------------------------------------------------------------------- Comment By: Michiel de Hoon (mdehoon) Date: 2005-03-27 02:20 Message: Logged In: YES user_id=488897 As mdr0 mentioned, skipitem misses code for several formats. This patch solves one, patch 985713 solves another one. Could you make a patch that solves all missing formats in skipitem? You can look at the convertsimple function to find all formats. ---------------------------------------------------------------------- Comment By: Mark D. Roth (mdr0) Date: 2004-07-05 23:39 Message: Logged In: YES user_id=994239 skipitem() is actually missing code for a number of other format units, in addition to "u" and "u#". See patch 985713 for more information. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=853890&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
