On Mon, Nov 09, 2015 at 03:39:09PM +0000, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 03:33:18PM +0000, Finucane, Stephen wrote: > > > PS: Since we're talking, if you have time to address the remaining > > comments > > > on the 'series' series it would be appreciated. I don't want to just do > > the > > > rework without you input in case I miss something. It's one of three > > blockers > > > for a 2.0 release, along with the Django 1.6 migrations (:() and > > interface > > > integration of series (Web UI and XML-RPC, until we get REST sorted). I'm > > > hoping 2.0 should be widely deployed, so it would be a nice kick to get > > this > > > feature in. > > > > Sorry, I don't have time to look at it. > > OK. Are you happy for me to rework as appropriate, including notes and > sign-offs in commit messages?
I forgot the most important part: I would strongly advice against merging the series support. This will make patchwork drop patches in certain corner cases. I'm still addressing those corner cases. The latest example I just fixed: http://lists.freedesktop.org/archives/wayland-devel/2015-November/025381.html Even without dropping patches -- there are a few known issues still -- the series/revision creation can sometimes be a bit unsettling because we are trying to guess the intent of the user. Last thing, series support hasn't reached the threshold I would consider good enough to make it into a release. At the very least the above has to be fixed, series status needs to happen (what is the state of a series based on the state of the underlying patches) and series filtering as well (just like patches, search capabilities and not display series with a state with action_required = True) HTH, -- Damien _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork