On 24 Nov 21:22, Finucane, Stephen wrote: > On 24 Nov 14:15, Jeremy Kerr wrote: > > Hi Stephen, > > > > >> The rehash script, though undocumented and possibly unused at the > > >> moment, likely has some value to some users. Howver, it makes more > > >> sense to provide this command as a management command like 'retag'. > > >> Do this. > > >> > > >> Signed-off-by: Stephen Finucane <[email protected]> > > > > > > I'm still not sure if this should be converted to a command or just > > > deleted. Does anyone use it? It seems like the hash could never really > > > get out of date without manual DB modification (in which case you have > > > more than one problem) thanks to the 'save' method. > > > > This was useful when the hashes were first introduced, but wouldn't be > > used much now. If we did need to change the hashing algorithm, (eg, move > > to SHA1, or change which parts of a patch are included in the hashed > > text), then it'd be required for that. > > > > I'd say keep it in, since you've already done the work converting it :) > > ...and that's exactly what I'll do. Thanks, Jeremy. > > Cheers, > Stephen
Merged. _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
