On 29 Nov 22:10, Stephen Finucane wrote: > After many nights of wrestling with unicode issues and the many other > Python2/3 discrepancies, I finally managed to get all unit tests to > pass under Python 3 (while retaining Python 2.7 support, naturally). > > patchwork needs Python 3 support. Python 3 is a better languages than > Python 2.7 and will replace it sooner rather than later. Django 2.0 is > still some years off, but when it arrives it will be the first version > to support only Python. Even now, some package maintainers are > packing Python 3-only versions of libraries like Django [1]. This is > happening and we need to embrace it. > > Because of the sheer amount of code this touches, I'd like some eyes on > these changes. Most of the changes were generated automatically, but > there are more than needed to be resolved manually. As such, the former > can probably be reviewed casually while the others require more > in-depth review. I'll work on expanding code coverage during my spare > time this week to see if I can root out any bugs. > > I'd also like an answer to the following questions: do we care about > Python 2.6? I've included imports for the 'absolute_import' future > import to retain some support, but I don't have any way to validate the > functionality without manually installing Python 2.6 (which I'm loathe > to do).
I'm aware that these changes introduce a lot of coding style violations, but I already have patches prepared to resolve these (and all other PEP8 issues). I'll push these once I get this merged. Stephen _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
