On 05/19/2016 02:03 AM, Finucane, Stephen wrote:
+    page_size = settings.REST_RESULTS_PER_PAGE
nit: This is already a DRF-provided setting that we can override:

   http://www.django-rest-framework.org/api-guide/settings/#page_size

However, Given the deprecation of other similar parameters, I'm fine to
stick with our own parameter (those settings might be worth reading
though, in case there's anything cool there :)).

I thought PAGE_SIZE was really generic and would wind up causing a comment line in code. So I figured using our own setting would make it more clear/obvious.
_______________________________________________
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork

Reply via email to