The schema for 'Check' defines 'Check.name' as a 'CharField'. This is
less than ideal as names with spaces and special characters can't be
represented cleanly in URLs etc. We should use 'SlugField' instead.
Signed-off-by: Stephen Finucane <stephen.finuc...@intel.com>
Reviewed-by: Andy Doan <andy.d...@linaro.org>
Closes: #33
---
v3:
- Rebase and rename migration file
---
patchwork/migrations/0013_slug_check_context.py | 19 +++++++++++++++++++
patchwork/models.py | 8 ++++----
2 files changed, 23 insertions(+), 4 deletions(-)
create mode 100644 patchwork/migrations/0013_slug_check_context.py
diff --git a/patchwork/migrations/0013_slug_check_context.py
b/patchwork/migrations/0013_slug_check_context.py
new file mode 100644
index 0000000..17e33aa
--- /dev/null
+++ b/patchwork/migrations/0013_slug_check_context.py
@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('patchwork', '0012_add_coverletter_model'),
+ ]
+
+ operations = [
+ migrations.AlterField(
+ model_name='check',
+ name='context',
+ field=models.SlugField(default=b'default', help_text=b'A label to
discern check from checks of other testing systems.', max_length=255),
+ ),
+ ]
diff --git a/patchwork/models.py b/patchwork/models.py
index 4d454c7..3141da2 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -577,12 +577,12 @@ class Check(models.Model):
help_text='The state of the check.')
target_url = models.URLField(
blank=True, null=True,
- help_text='The target URL to associate with this check. This should'
- ' be specific to the patch.')
+ help_text='The target URL to associate with this check. This should '
+ 'be specific to the patch.')
description = models.TextField(
blank=True, null=True, help_text='A brief description of the check.')
- context = models.CharField(
- max_length=255, default='default', blank=True, null=True,
+ context = models.SlugField(
+ max_length=255, default='default',
help_text='A label to discern check from checks of other testing '
'systems.')
--
1.7.4.1
_______________________________________________
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
