On Mon, 2017-01-23 at 10:17 -0800, Florian Fainelli wrote: > On 01/23/2017 01:54 AM, Rafał Miłecki wrote: > > On 19 January 2017 at 02:36, Florian Fainelli <[email protected] > > > wrote: > > > A lot of project these days have adopted the Linux tags for their > > > commit > > > messages. Augment the default fixtures with a bunch of commonly > > > found > > > tags: Reviewed-by, Reported-by, Suggested-by, Signed-off-by, > > > Tested-by, > > > and finally Fixes which is increasingly popular (at least for > > > Linux) > > > > Does it allow replying with a tag that will be picked by a > > patchwork? > > Yes, that's the idea. > > > > > Right now I can reply with Acked-by, does this patch allow replying > > with e.g. Reviewed-by or Tested-by? This sounds like a worth > > feature, > > however *counting* tags like Reported-by or Fixes (and adding > > count-column for each) sounds useless. > > Well, not sure if you mean that Tested-by and Fixes are useless in > amending the patch with them, I think all tags, but these two in > particular have value landing in the final mbox file (useful for > -stable > backports for instance). > > If you are talking about the column count displayed in the patch > listing, I agree, not all of them make sense to be displayed here. > > Right now there does not appear to be an attribute specifying how > they > could be hidden/displayed (but presumably could be added).
Very much so. The way that we append the responses to the mbox files [1] differs from how we display the patches in the UI [2]. If you could unify this (perhaps by way of a new "enable display" field on the Tag model?), then I imagine a variant of the original patch could be used. Stephen [1] https://github.com/getpatchwork/patchwork/blob/master/patchwork/mod els.py#L282-L292 [2] https://github.com/getpatchwork/patchwork/blob/master/patchwork/mod els.py#L366-L396 _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
