On Wed, 2018-01-17 at 14:26 -0500, David Miller wrote: > From: Stephen Finucane <step...@that.guru> > Date: Wed, 17 Jan 2018 19:09:29 +0000 > > > On Mon, 2018-01-15 at 13:25 -0500, David Miller wrote: > >> I've noticed for a while now that various pull requests are not > >> being recognized by patchwork.ozlabs.org and therefore don't > >> end up in the patchwork queue. > >> > >> Even ones I send myself are having this problem. All I am doing > >> is putting the contents of "git request-pull ..." into an email > >> and adding some other informative text to the beginning. > >> > >> I attach two examples of pull requests that patchwork at ozlabs > >> didn't queue up. > >> > >> Thanks! > > > > Here's our issue: > > > > https://github.com/git/git/commit/e66d7c37a5f > > > > The regex we used to detect these mails was case sensitive. I can > > submit a patch to simply make this case insensitive, which should > > resolve this issue. However, I also noticed that the file, as > > downloaded by my email client (Evolution), has CRLF line endings. > > > > $ file ~/Downloads/net_pull.txt > > /home/sfinucan/Downloads/net_pull.txt: ASCII text, with CRLF, CR > line terminators > > > > I can't see how this would happen with 'git-request-pull', so can I > > safely assume it's my email client messing up here? > > Here is the attachment again, sent as Application/Octet-Stream > instead > of Text/Plain, see if it makes a difference:
Yup, now we've got plain old ASCII, as expected. $ file ~/Downloads/net_pull.txt /home/sfinucan/Downloads/net_pull.txt: ASCII text I'll send out the patch shortly and backport to stable/2.0 once that's done. From there, it's up to Jeremy and the Ozlabs peeps to drag it in for patchwork.ozlabs.org. Stephen _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork