Stephen Finucane <step...@that.guru> writes: > On Thu, 2018-02-22 at 16:24 +0100, vkaba...@redhat.com wrote: >> From: Veronika Kabatova <vkaba...@redhat.com> >> >> Patchwork saves patches, comments etc with UTC timezone and reports >> this time when opening the patch details. However, internally generated >> processes such as events are reported with the instance's local time. >> There's nothing wrong with that and making PW timezone-aware would add >> useless complexity, but in a world-wide collaboration a lot of confusion >> may arise as the timezone is not reported at all. Instance's local time >> might be very different from the local time of CI integrating with PW, >> which is different from the local time of person dealing with it etc. >> >> Use UTC everywhere by default instead of UTC for sumbissions and local >> timezone for internally generated events (which is not reported). >> >> Signed-off-by: Veronika Kabatova <vkaba...@redhat.com> > > This all looks good to me and you've resolved Daniel's once outstanding > comment via the additional reno. As such, > > Reviewed-by: Stephen Finucane <step...@that.guru> > > I'll give it a few days to give Daniel the chance to sign off before > applying this.
Sounds good; I just wanted to check that what is stored in the database makes sense before and after. [I'm not intuitively sure what TZ the DB will use and I'd like to have a quick look and compare that with the docs and just check we're not doing anything stupid. My concern would be if we're creating a time as utc and the db/django is interpreting it as in the instance timezone and then converting it to UTC again to store, so we end up storing a time in a totally weird and meaningless timezone. That or MySQL/Postgres differences that I at least want to be aware of.] I should get this applied in the next couple of days. Regards, Daniel > > Stephen > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
