On Wed, 2019-09-18 at 16:17 +1000, Daniel Axtens wrote:
> Currently if we have particular types of error in mail parsing
> in parsearchive or parsemail, we print exc.message, which doesn't
> always work:
>
> Traceback (most recent call last):
> File
> "/home/patchwork/patchwork/patchwork/management/commands/parsearchive.py",
> line 90, in handle
> obj = parse_mail(msg, options['list_id'])
> File "/home/patchwork/patchwork/patchwork/parser.py", line 961, in
> parse_mail
> raise ValueError("Missing 'Message-Id' header")
> ValueError: Missing 'Message-Id' header
>
> During handling of the above exception, another exception occurred:
>
> Traceback (most recent call last):
> File "manage.py", line 11, in <module>
> execute_from_command_line(sys.argv)
> File
> "/opt/pyenv/versions/3.7.4/lib/python3.7/site-packages/django/core/management/__init__.py",
> line 381, in execute_from_command_line
> utility.execute()
> File
> "/opt/pyenv/versions/3.7.4/lib/python3.7/site-packages/django/core/management/__init__.py",
> line 375, in execute
> self.fetch_command(subcommand).run_from_argv(self.argv)
> File
> "/opt/pyenv/versions/3.7.4/lib/python3.7/site-packages/django/core/management/base.py",
> line 323, in run_from_argv
> self.execute(*args, **cmd_options)
> File
> "/opt/pyenv/versions/3.7.4/lib/python3.7/site-packages/django/core/management/base.py",
> line 364, in execute
> output = self.handle(*args, **options)
> File
> "/home/patchwork/patchwork/patchwork/management/commands/parsearchive.py",
> line 100, in handle
> logger.warning('Invalid mail: %s', exc.message)
> AttributeError: 'ValueError' object has no attribute 'message'
>
> repr(exc) will work. Use it.
>
> Signed-off-by: Daniel Axtens <[email protected]>
Reviewed-by: Stephen Finucane <[email protected]>
and applied (with some minor tweaks to the commit message).
_______________________________________________
Patchwork mailing list
[email protected]
https://lists.ozlabs.org/listinfo/patchwork
