On Sat, 2019-09-21 at 10:32 -0500, Bjorn Helgaas wrote:
> Hello,
>
> I'm trying to get started with git-pw (or pwclient, but I have the
> impression that's the old stuff, and I don't think it supports things
> like delegating patches), but I feel like I'm banging my head against
> the wall. Maybe something isn't installed or configured right; I'd
> appreciate any hints.
>
> Running latest git-pw (1a71697687e1 ("Handle integers too when
> printing CSV")), I get annoying "Server version missing" messages when
> I *do* supply the version, but the operation actually doesn't work:
>
> $ git config -l | grep "^pw"
> pw.server=https://patchwork.ozlabs.org/api/2.1.3
> pw.project=linux-pci
> pw.token=<...>
2.1.3 is the Patchwork version, not the _API_ version. You want 1.1
[1]. I should probably clarify that these are different things in the
git-pw docs. Sorry for the confusion.
> $ git-pw patch list
> Server version missing
> You should provide the server version in the URL configured via git-config
> or --server
> This will be required in git-pw 2.0
> ...
> Resource not found
>
> OK, so I drop the version from the URL (and still get the "version
> missing" messages, which at least make sense now), and the operation
> *does* work:
>
> $ git config -l | grep "^pw"
> pw.server=https://patchwork.ozlabs.org
> pw.project=linux-pci
> pw.token=<...>
>
> $ git-pw patch list | cat
> Server version missing
> You should provide the server version in the URL configured via git-config
> or --server
> This will be required in git-pw 2.0
> ...
>
> +---------+------------+--------------------------------------------------------------------------+---------------------------------------------------------+---------+------------+------------+
> | ID | Date | Name
> | Submitter
> | State | Archived | Delegate |
>
> |---------+------------+--------------------------------------------------------------------------+---------------------------------------------------------+---------+------------+------------|
> | 1164343 | 2 days ago | PCI: Enhance the ACS quirk for Cavium devices
> | George Cherian (george.cher...@marvell.com)
> | new | no | |
> ...
>
> And I think I should be able to delegate patches via git-pw, but that
> doesn't work. I assume this is just user error or misconfiguration:
>
> $ git-pw patch update --delegate bhelgaas 1164343
> ...
> {u'delegate': [u"User 'bhelgaas' is not a maintainer for project 'Linux PCI
> development'"]}
>
> $ git-pw patch update --delegate bhelg...@google.com 1164343
> ...
> {u'delegate': [u"User 'bhelgaas' is not a maintainer for project 'Linux PCI
> development'"]}
>
> $ git-pw patch update --delegate "Bjorn Helgaas" 1164343
> ...
> {u'delegate': [u"User 'bhelgaas' is not a maintainer for project 'Linux PCI
> development'"]}
>
> Is this stuff that is supposed to work, or do I just need to wait?
It should work, and the reason it doesn't is because of a bug. I've
opened a report for this [3] and will have a patch available shortly,
though it could be some time before ozlabs actually pull it, I'm afraid
:(
Let me know if any of that is unclear.
Stephen
> I'm sort of puzzled about the server version stuff, because it seems
> like anybody using this with patchwork.ozlabs.org should be seeing the
> same thing.
>
> Bjorn
[1] https://patchwork.readthedocs.io/en/latest/api/rest/#supported-versions
[2] http://patchwork.ozlabs.org/project/linux-pci/
[3] https://github.com/getpatchwork/patchwork/issues/313
_______________________________________________
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
